[Tests] Fix test retries for Pulsar Functions integration tests #10565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TestRetrySupport will call the cleanup & setup methods between test retries to enable test retries. Test retries for Pulsar Functions were broken since Functions Worker wasn't part of these calls. - The change also ensures correct startup order so that the Pulsar cluster is started before the Functions worker. When running tests on JDK11 there were odd test failures that indicated an incorrect startup order. The problems went away with these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
TestRetrySupportwill call the cleanup & setup methods between test retries to enable test retries.Test retries for Pulsar Functions integration tests were broken since Functions Worker setup/teardown wasn't part of these calls.
The change also ensures correct startup order so that the Pulsar cluster is started before the Functions worker.
When running tests on JDK11 there were odd test failures that indicated an incorrect startup order.
The problems went away with these changes. These changes are necessary for running integration tests on JDK11.
Modifications
@BeforeClassannotation fromsetupFunctionWorkersmethod and call it in an overriddensetupClustermethod.@AfterClassannotation fromteardownFunctionWorkersmethod and call it in an overriddentearDownClustermethod.