Skip to content

[Tests] Fix KeyStoreTlsTest on JDK11 #10345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2021
Merged

[Tests] Fix KeyStoreTlsTest on JDK11 #10345

merged 1 commit into from
Apr 25, 2021
+26 −40

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Apr 23, 2021

Motivation

KeyStoreTlsTest hangs on JDK11 currently. It seems that the internal state engine is different than what SSLContextValidatorEngine expects.

Modifications

@lhotari
Copy link
Member Author

lhotari commented Apr 23, 2021

@eolivelli @merlimat Please review

eolivelli
eolivelli approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lhotari
Copy link
Member Author

lhotari commented Apr 23, 2021

/pulsarbot run-failure-checks

@lhotari
Copy link
Member Author

lhotari commented Apr 25, 2021

@merlimat Please review

@merlimat merlimat added this to the 2.8.0 milestone Apr 25, 2021
@merlimat merlimat merged commit 217aed9 into apache:master Apr 25, 2021
lhotari added a commit to datastax/pulsar that referenced this pull request May 14, 2021
@lhotari
Fix KeyStoreTlsTest on JDK11 (apache#10345)
8c3787f
@tisonkun tisonkun mentioned this pull request Dec 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merlimat merlimat merlimat approved these changes

@eolivelli eolivelli eolivelli approved these changes

Assignees

@lhotari lhotari

Labels

area/test

Projects

None yet

Milestone

2.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@lhotari @merlimat @eolivelli