Fix some ExecutorService leaks #10198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
approved these changes
Apr 12, 2021
codelipenghui
approved these changes
Apr 13, 2021
…eanup - use ExecutorService.shutdownNow() instead of ExecutorService.shutdown() in tests
lhotari
force-pushed
the
lh-cleanup-executors
branch
from
b2eb1d6 to
7cbd1e8
Compare
sijie
approved these changes
Apr 13, 2021
Member
|
/pulsarbot run-failure-checks |
2 similar comments
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some tests don't close all ExecutorServices created in tests. There were also a few issues in production code where ExecutorServices weren't closed.
Modifications
@Cleanup("shutdownNow")for calling the.shutdownNow()method.shutdownNow()instead ofshutdown()so that executors are closed asap instead of waiting for in-progress tasks to complete.