Skip to content

Conversation

@gulecroc
Copy link
Contributor

@gulecroc gulecroc commented Jan 22, 2025

Motivation

To test geo-replication, I would like to install the pulsar chart 3 times :

  • 1 for global zookeeper
  • 2 for 2 pulsar clusters

I also would like to use TLS. The global zookeeper install will create the CA issuer and certificate, and the 2 pulsar clusters will use it to create their certificates.

Modifications

  • add template to override CA issuer name and certificate secret name

Verifying this change

  • Make sure that the change passes the CI checks.

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @gulecroc . Please remove the geo-replication changes out of this PR since that will simplify handling of this PR so that we first get the TLS templating changes made.
We can handle the geo-replication examples in a separate PR.

I really appreciate your effort in making a Geo-replication example available directly in the Pulsar helm chart.
One minor detail is that global Zookeeper isn't required in Pulsar to use geo-replication. For completeness of the examples, it would be useful to then have examples of both cases. The Pulsar documentation doesn't clearly explain the different ways Pulsar geo-replication can be configured.

@gulecroc
Copy link
Contributor Author

Hi @lhotari,

I remove the geo-replication doc.
I don't think it's necessarry to add .Values.certs.internal_issuer.type cases in the certs template because we could also set ca name and secretName values for selfsigning ?

@lhotari lhotari changed the title set template for ca issuer name and secret name + geo-replication installation example add template for ca issuer name and secret name May 23, 2025
@lhotari lhotari merged commit 1180db4 into apache:master May 23, 2025
31 checks passed
@gulecroc gulecroc deleted the custom-tls-names branch June 13, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants