Fix Variant int64 example binary data #85
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @mapleFU pointed out, the binary vale of
primtive_int64actually contains an int32 as it appears Spark truncates variant values to the smallest type that will fit itChanges
I also manually verified the output binary is correct:
$ xxd primitive_int64.value 00000000: 1815 81e9 7df4 1022 11 ....}..".we see the first byte is
0x18the first byte
0x18is0b000110000b00=>Primitive type0b000110==> 6Per the encoding grammar for Variant basic types) table, primitive_type =
6corresponds toint64: