Skip to content

PARQUET-974: Add a special ColumnOrder for testing #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lekv wants to merge 1 commit into from
Closed

PARQUET-974: Add a special ColumnOrder for testing #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@

thrift:
mkdir -p generated
thrift --gen cpp -o generated src/thrift/parquet.thrift
thrift --gen java -o generated src/thrift/parquet.thrift
thrift --gen cpp -o generated src/main/thrift/parquet.thrift
thrift --gen java -o generated src/main/thrift/parquet.thrift
10 changes: 8 additions & 2 deletions src/main/thrift/parquet.thrift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,8 +578,9 @@ struct RowGroup {
4: optional list<SortingColumn> sorting_columns
}

/** Empty struct to signal the order defined by the physical or logical type */
/** Empty structs to signal the order defined by the physical or logical type */
struct TypeDefinedOrder {}
struct InvalidOrder {}

/**
* Union to specify the order used for min, max, and sorting values in a column.
Expand All @@ -588,11 +589,16 @@ struct TypeDefinedOrder {}
* * TypeDefinedOrder - the column uses the order defined by its logical or
* physical type (if there is no logical type).
*
* * InvalidOrder - the column uses an invalid order that no reader should support.
* This order can be used to test logic to exclude unsupported orders
* and should not be used otherwise.
*
* If the reader does not support the value of this union, min and max stats
* for this column should be ignored.
*/
union ColumnOrder {
1: TypeDefinedOrder TYPE_ORDER;
1: TypeDefinedOrder TYPE_ORDER
2: InvalidOrder INVALID_ORDER
}

/**
Expand Down