Minor: Small documentation fixes and deduplication #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Member
|
The duplicate sort order description was introduced by #185 WDYT? @emkornfield @gszadovszky @pitrou |
gszadovszky
approved these changes
Apr 15, 2025
wgtmac
approved these changes
Apr 17, 2025
Member
jiayuasu
pushed a commit
to jiayuasu/parquet-format
that referenced
this pull request
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the small documentation fixes that were pulled out of PR#221, as it was suggested that they should go into an own PR.
Mostly, this is small format and and content fixes. The only larger change is that the explanation of comparison rules was deduplicated out of
LogicalTypes.md, as the same text is also inparquet.thriftand keeping such duplicate documentation in sync is hard. Instead,LogicalTypes.mdjust points toparquet.thrift. Deduplicating this is especially important for PR#221, as that PR introduces a new column ordering and thus makes the ordering rules even larger, so having them duplicated is becoming even a bigger burden.