Skip to content

HDDS-11785. DataNode aborts ContainerStateMachine if it does not know any follower next index #7480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jojochuang merged 2 commits into from
Nov 26, 2024
Merged

HDDS-11785. DataNode aborts ContainerStateMachine if it does not know any follower next index #7480

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
965beec
HDDS-11785. DataNode aborts state machine because ContainerStateMachi…
jojochuang Nov 23, 2024
1abd500
Update to address Attila's comments.
jojochuang Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rg/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,7 +1006,7 @@ private void removeStateMachineDataIfNeeded(long index) {
RaftServer.Division division = ratisServer.getServer().getDivision(getGroupId());
if (division.getInfo().isLeader()) {
long minIndex = Arrays.stream(division.getInfo()
.getFollowerNextIndices()).min().getAsLong();
.getFollowerNextIndices()).min().orElse(0);
LOG.debug("Removing data corresponding to log index {} min index {} "
+ "from cache", index, minIndex);
removeCacheDataUpTo(Math.min(minIndex, index));
Copy link
Contributor

@adoroszlai adoroszlai Nov 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jojochuang for the patch.

Should it removeCacheDataUpTo only if minIndex is found?

Arrays.stream(division.getInfo().getFollowerNextIndices())
    .min()
    .ifPresent(minIndex -> removeCacheDataUpTo(Math.min(minIndex, index)));

Also, would be nice to rethrow unchecked exceptions directly:

try {
  ...
} catch (RuntimeException e) {
  throw e;
} catch (Exception e) {
  throw new RuntimeException(e);
}

Copy link
Contributor Author

@jojochuang jojochuang Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's essentially the same, but your suggest is more readable. Will update accordingly.

Expand Down