Skip to content

HDDS-7732. EC: Verify unrecoverable EC containers which are empty transition to deleting #4705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sodonnel merged 1 commit into from
May 12, 2023
Merged

HDDS-7732. EC: Verify unrecoverable EC containers which are empty transition to deleting #4705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion ...rc/test/java/org/apache/hadoop/hdds/scm/container/replication/TestReplicationManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ public void setup() throws IOException {

Mockito.when(containerManager.getContainers()).thenAnswer(
invocation -> new ArrayList<>(containerInfoSet));

replicationManager = createReplicationManager();
containerReplicaMap = new HashMap<>();
containerInfoSet = new HashSet<>();
Expand Down Expand Up @@ -502,6 +501,34 @@ public void testUnderReplicatedAndUnrecoverable()
ReplicationManagerReport.HealthState.MISSING));
}

@Test
public void testUnrecoverableAndEmpty()
throws ContainerNotFoundException {
ContainerInfo container = createContainerInfo(repConfig, 1,
HddsProtos.LifeCycleState.CLOSED);

ContainerReplica replica = createContainerReplica(container.containerID(),
1, IN_SERVICE, ContainerReplicaProto.State.CLOSED,
0, 0, MockDatanodeDetails.randomDatanodeDetails(), UUID.randomUUID());

storeContainerAndReplicas(container, Collections.singleton(replica));

replicationManager.processContainer(container, repQueue, repReport);
// If it is unrecoverable, there is no point in putting it into the under
// replication list. It will be checked again on the next RM run.
Assert.assertEquals(0, repQueue.underReplicatedQueueSize());
Assert.assertEquals(0, repQueue.overReplicatedQueueSize());
Assert.assertEquals(0, repReport.getStat(
ReplicationManagerReport.HealthState.UNDER_REPLICATED));
Assert.assertEquals(0, repReport.getStat(
ReplicationManagerReport.HealthState.MISSING));
// As it is marked empty in the report, it must have gone through the
// empty container handler, indicating is was handled as empty.
Assert.assertEquals(1, repReport.getStat(
ReplicationManagerReport.HealthState.EMPTY));
}


/**
* A closed EC container with 3 closed and 2 unhealthy replicas is under
* replicated. RM should add it to under replicated queue.
Expand Down