HDDS-8530. [Snapshot] Fix for OM crash on restart due to snapshot chain manager corruption #4677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemantk-12
changed the title
smengcl
reviewed
May 17, 2023
...ne/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHASnapshot.java
Outdated
Show resolved
Hide resolved
smengcl
reviewed
May 17, 2023
...ne/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHASnapshot.java
Show resolved
Hide resolved
smengcl
reviewed
May 17, 2023
Contributor
smengcl
left a comment
smengcl
left a comment
There was a problem hiding this comment.
Thanks @hemantk-12 for the fix!
aswinshakil
reviewed
May 17, 2023
Member
aswinshakil
left a comment
aswinshakil
left a comment
There was a problem hiding this comment.
Thanks for working this @hemantk-12 . LGTM. Just have a few minor comments.
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/SnapshotChainManager.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/SnapshotChainManager.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/SnapshotChainManager.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Aswin Shakil Balasubramanian <[email protected]>
Contributor
|
Thanks @aswinshakil for reviewing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
OM was crashing on the restart because snapshot chain was getting corrupted. On the deep dive, it is found that it is because creation time of snapshots are not unique among snapshots and causing the failure. Mode details are in jira: https://issues.apache.org/jira/browse/HDDS-8530.
This change is to pass the creation time through preExecute instead of each OM node using current time as creation time. Creation time is passed similar to
snapshotId.This change also includes some logging changes in
SnapshotChainManagerto log more information to debug in future.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8530
How was this patch tested?
Added integration test to verify.