Skip to content

refactor: Remove not needed types in icloud #4021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xuanwo merged 3 commits into from
Jan 19, 2024
Merged

refactor: Remove not needed types in icloud #4021

Xuanwo merged 3 commits into from
Jan 19, 2024

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 19, 2024

No description provided.

@Xuanwo Xuanwo requested a review from PsiACE as a code owner January 19, 2024 05:33
@github-actions github-actions bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Jan 19, 2024
@github-actions github-actions bot requested review from G-XD and xyjixyjixyji January 19, 2024 05:35
@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 19, 2024

cc @bokket to help take a review

@bokket
Copy link
Contributor

bokket commented Jan 19, 2024

Thanks! nice for me.I am also testing whether X-Apple-Widget-Key(authServiceKey) can be obtained by Tunes Connect Endpoint

@bokket
Copy link
Contributor

bokket commented Jan 19, 2024 •
edited
Loading

it failed in

core/src/raw/http_util/client.rs:110:58:
input request url must be valid: RelativeUrlWithoutBase

Let me go back to it

@Xuanwo Xuanwo merged commit 6c8b049 into main Jan 19, 2024
@Xuanwo Xuanwo deleted the refactor-icloud branch January 19, 2024 09:02
@Zheaoli Zheaoli mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PsiACE PsiACE PsiACE approved these changes

@G-XD G-XD Awaiting requested review from G-XD

@xyjixyjixyji xyjixyjixyji Awaiting requested review from xyjixyjixyji

Assignees

No one assigned

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Xuanwo @bokket @PsiACE