Skip to content

chore: simplify reviewer candidates logic #4017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xuanwo merged 1 commit into from
Jan 19, 2024
Merged

chore: simplify reviewer candidates logic #4017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,3 @@
/bindings/nodejs/ @suyanhanx
/bindings/python/ @messense @Zheaoli
/bindings/ruby/ @PsiACE

# This is a place holder for all committers who what to join the review of not owned code.
#
# More details could be found at <https://github.com/apache/opendal/issues/3967>
COMMITTERS_PLACEHOLDER @Xuanwo @Ji-Xinyou @morristai @dqhl76 @ClSlaid @Young-Flash @G-XD @oowl @silver-ymz
36 changes: 17 additions & 19 deletions .github/scripts/assign_reviewers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,33 +17,31 @@
* under the License.
*/

// All committers who what to join the review of not owned code.
// More details could be found at https://github.com/apache/opendal/issues/3967.
const candidates = [
"Xuanwo",
"Ji-Xinyou",
"morristai",
"dqhl76",
"ClSlaid",
"Young-Flash",
"G-XD",
"oowl",
"silver-ymz",
];

async function run(github, context, core, fs) {
try {
// Pick two reviewers from list
const numberOfReviewers = 2;
const repo = context.repo;

// Read CODEOWNERS
const codeownersContent = fs.readFileSync('.github/CODEOWNERS', 'utf8');
const lines = codeownersContent.split('\n');

// Search COMMITTERS
const placeholderLine = lines.find(line => line.startsWith('COMMITTERS_PLACEHOLDER'));
if (!placeholderLine) {
throw new Error("No COMMITTERS found in CODEOWNERS");
}

// Extract committers from placeholder line
const committers = placeholderLine.match(/@[\w-]+/g).map(u => u.substring(1));
if (committers.length === 0) {
throw new Error("No committer found in COMMITTERS_PLACEHOLDER");
}

// Pick reviewers
const selectedReviewers = [];
while (selectedReviewers.length < numberOfReviewers && committers.length > 0) {
const randomIndex = Math.floor(Math.random() * committers.length);
selectedReviewers.push(committers.splice(randomIndex, 1)[0]);
while (selectedReviewers.length < numberOfReviewers && candidates.length > 0) {
const randomIndex = Math.floor(Math.random() * candidates.length);
selectedReviewers.push(candidates.splice(randomIndex, 1)[0]);
}

// Assign reviewers Pull Request
Expand Down