Skip to content

feat: add concurrent and buffer parameters into FuzzInput #3921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xuanwo merged 2 commits into from
Jan 6, 2024
Merged

feat: add concurrent and buffer parameters into FuzzInput #3921

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80bba51
feat: add `concurrent` and `buffer` input writer `FuzzInput`
WenyXu Jan 5, 2024
bee1987
chore: apply suggestions from CR
WenyXu Jan 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions core/fuzz/fuzz_writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,15 @@ const MAX_DATA_SIZE: usize = 16 * 1024 * 1024;
#[derive(Debug, Clone)]
struct FuzzInput {
actions: Vec<WriteAction>,
concurrent: usize,
buffer: usize,
}

impl Arbitrary<'_> for FuzzInput {
fn arbitrary(u: &mut Unstructured<'_>) -> arbitrary::Result<Self> {
let mut actions = vec![];
let concurrent = u.int_in_range(0..=16)?;
let buffer = u.int_in_range(2 * 1024 * 1024..=8 * 1024 * 1024)?;

let count = u.int_in_range(128..=1024)?;

Expand All @@ -45,7 +49,11 @@ impl Arbitrary<'_> for FuzzInput {
actions.push(WriteAction::Write(size));
}

Ok(FuzzInput { actions })
Ok(FuzzInput {
actions,
concurrent,
buffer,
})
}
}

Expand All @@ -62,7 +70,11 @@ async fn fuzz_writer(op: Operator, input: FuzzInput) -> Result<()> {

let checker = WriteChecker::new(total_size);

let mut writer = op.writer_with(&path).buffer(8 * 1024 * 1024).await?;
let mut writer = op
.writer_with(&path)
.buffer(input.buffer)
.concurrent(input.concurrent)
.await?;

for chunk in checker.chunks() {
writer.write(chunk.clone()).await?;
Expand Down