Skip to content

refactor!: Bump MSRV to 1.75 #3851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xuanwo merged 3 commits into from
Jan 6, 2024
Merged

refactor!: Bump MSRV to 1.75 #3851

Xuanwo merged 3 commits into from
Jan 6, 2024

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Dec 29, 2023

close #3720

@Xuanwo Xuanwo requested a review from PsiACE as a code owner December 29, 2023 04:25
@Xuanwo Xuanwo requested review from suyanhanx and tisonkun December 29, 2023 04:25
@github-actions github-actions bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Dec 29, 2023
@suyanhanx
Copy link
Member

suyanhanx commented Dec 29, 2023

Do we need to take into account the downstream's MSRV?

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 29, 2023

Do we need to take into account the downstream's MSRV?

Almost all of our users are applications, so it's acceptable for them to increase the MSRV. Only the iceberg-rs library has decided to upgrade to version 1.75 since other deps will bump too.

suyanhanx
suyanhanx approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 29, 2023

Don't merge before we published 0.44

@Xuanwo Xuanwo marked this pull request as draft December 29, 2023 08:39
@Xuanwo Xuanwo marked this pull request as ready for review January 6, 2024 11:22
@Xuanwo Xuanwo merged commit 3edaa8f into main Jan 6, 2024
@Xuanwo Xuanwo deleted the bump-msrv branch January 6, 2024 11:33
Xuanwo added a commit that referenced this pull request Jan 9, 2024
@Xuanwo
Revert "refactor!: Bump MSRV to 1.75 (#3851)"
643ed93 
This reverts commit 3edaa8f.
Xuanwo added a commit that referenced this pull request Jan 9, 2024
@Xuanwo
refactor!: Revert the bump of MSRV to 1.75 (#3952)
b956b76 
Revert "refactor!: Bump MSRV to 1.75 (#3851)"

This reverts commit 3edaa8f.
@Zheaoli Zheaoli mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@PsiACE PsiACE PsiACE approved these changes

@tisonkun tisonkun Awaiting requested review from tisonkun tisonkun is a code owner

Assignees

No one assigned

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

idea: Bump MSRV to rust 1.75 once it's ready

3 participants

@Xuanwo @suyanhanx @PsiACE