This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[gluon][transform]fix unpicklable transform_first on windows#13686
Merged
eric-haibin-lin merged 1 commit intoapache:masterfrom Dec 19, 2018
Merged
[gluon][transform]fix unpicklable transform_first on windows#13686eric-haibin-lin merged 1 commit intoapache:masterfrom
eric-haibin-lin merged 1 commit intoapache:masterfrom
Conversation
Member
Author
Member
|
Thanks for the fix! |
Member
Author
|
@eric-haibin-lin Can you help review and merge? Aston is eager to include it in 1.4 so readers using windows don't need to struggle with dependencies. |
eric-haibin-lin
pushed a commit
to eric-haibin-lin/mxnet
that referenced
this pull request
Dec 19, 2018
7 tasks
7 tasks
astonzhang
added a commit
to astonzhang/incubator-mxnet
that referenced
this pull request
Dec 19, 2018
eric-haibin-lin
pushed a commit
that referenced
this pull request
Dec 19, 2018
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow windows user to properly use
Dataset.transform_firstin combination withnum_workers > 0The original problem is caused by nested function which cannot be pickled in
transform_firstReproduceable following http://en.diveintodeeplearning.org/chapter_deep-learning-basics/fashion-mnist.html and set num_workers > 0 on windows machine
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.