Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

enable CPU kernel for all RNN layer forward#11807

Merged
eric-haibin-lin merged 1 commit intoapache:masterfrom
szha:gluon_rnn_test
Jul 19, 2018
Merged

enable CPU kernel for all RNN layer forward#11807
eric-haibin-lin merged 1 commit intoapache:masterfrom
szha:gluon_rnn_test

Conversation

@szha
Copy link
Member

@szha szha commented Jul 18, 2018

Description

After #10104, #10311, and #11399 are merged, rnn operator's CPU implementation is compatible with GPU implementation.

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests already cover it.
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • always use CPU kernel for RNN layer forward.

Comments

@szha szha requested a review from eric-haibin-lin July 18, 2018 23:21
@eric-haibin-lin
Copy link
Member

@zheng-da does this help your case?

Copy link
Member

@eric-haibin-lin eric-haibin-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we already have unit test for this?

@szha
Copy link
Member Author

szha commented Jul 19, 2018

Plenty with {cpu, gpu} * {ndarray, symbol} coverage.

@eric-haibin-lin eric-haibin-lin merged commit 9b30af2 into apache:master Jul 19, 2018
@szha szha deleted the gluon_rnn_test branch July 19, 2018 04:10
KellenSunderland pushed a commit to KellenSunderland/incubator-mxnet that referenced this pull request Jul 21, 2018
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants