Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-616] Add licenses to files introduced by clojure package #11205#11512

Merged
marcoabreu merged 1 commit intoapache:masterfrom
marcoabreu:fix-closure-licenses
Jul 1, 2018
Merged

[MXNET-616] Add licenses to files introduced by clojure package #11205#11512
marcoabreu merged 1 commit intoapache:masterfrom
marcoabreu:fix-closure-licenses

Conversation

@marcoabreu
Copy link
Contributor

@marcoabreu marcoabreu commented Jul 1, 2018

Description

Add licenses to files introduced by clojure package #11205

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Add licenses to clojure files

Comments

  • @gigasquid please review. I'm not sure if the comments (especially for the testviz) are correct.

Copy link
Member

@gigasquid gigasquid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing!

The only modification is that the testviz file can actually be deleted. It was checked in by mistake. Feel free to do it on this PR or I can do it in my next PR.

@marcoabreu
Copy link
Contributor Author

Thank you! It'd be great if you could do it as part of a separate PR.

@marcoabreu marcoabreu merged commit 37c8165 into apache:master Jul 1, 2018
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants