This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-555] Add subgraph storage type inference to CachedOp #11306
Merged
piiswrong merged 9 commits intoapache:masterfrom Jun 21, 2018
Merged
[MXNET-555] Add subgraph storage type inference to CachedOp #11306piiswrong merged 9 commits intoapache:masterfrom
piiswrong merged 9 commits intoapache:masterfrom
Conversation
eric-haibin-lin
changed the title
eric-haibin-lin
changed the title
eric-haibin-lin
changed the title
eric-haibin-lin
changed the title
eric-haibin-lin
changed the title
zheng-da
reviewed
Jun 17, 2018
| exec::DevMaskVector dev_masks(idx.num_nodes(), dev_mask); | ||
|
|
||
| // Full graph storage type inference | ||
| CheckAndInferStorageType(&g, std::move(dev_masks), std::move(stypes), false); |
Contributor
There was a problem hiding this comment.
should we use exec::InferShape(std::move(g))? Is it guaranteed that the inference works in one invocation?
Member
Author
There was a problem hiding this comment.
i haven't seen cases where storage type inference requires multiple runs since it doesn't use outputs to infer inputs. did you?
Contributor
There was a problem hiding this comment.
i don't know. but it's easy to make it work for multiple runs.
eric-haibin-lin
changed the title
eric-haibin-lin
changed the title
zheng-da
approved these changes
Jun 21, 2018
9 tasks
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
…1306) * copy paste * pass unit test * remove lock * save all inputs and outputs * add one more test * update test * update backward stype inference * + fwd inference
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
…1306) * copy paste * pass unit test * remove lock * save all inputs and outputs * add one more test * update test * update backward stype inference * + fwd inference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #11206
@zheng-da @piiswrong @reminisce
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments