-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Deduplicate filtered dependency graph #2489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
slawekjaranowski
merged 2 commits into
apache:maven-3.9.x
from
alzimmermsft:DeduplicateFilteredDependencyGraph
Jun 18, 2025
Merged
Deduplicate filtered dependency graph #2489
slawekjaranowski
merged 2 commits into
apache:maven-3.9.x
from
alzimmermsft:DeduplicateFilteredDependencyGraph
Jun 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekjaranowski
approved these changes
Jun 17, 2025
cstamas
approved these changes
Jun 18, 2025
|
Thank you for contribution! 🍻 |
|
Glad to help @cstamas! If this is also an issue in master, I'm happy to file a PR against it as well. |
|
Feel free to do so! Let the beer flow... 😄 |
olamy
approved these changes
Jun 18, 2025
8 tasks
cstamas
pushed a commit
that referenced
this pull request
Jun 19, 2025
cstamas
added a commit
to cstamas/maven
that referenced
this pull request
Jun 19, 2025
Port of apache#2489 against master. Fixes apache#2487
dongjoon-hyun
added a commit
to apache/orc
that referenced
this pull request
Jul 15, 2025
### What changes were proposed in this pull request? This PR aims to upgrade Maven to 3.9.11. ### Why are the changes needed? To bring the latest bug fixes. - https://github.com/apache/maven/releases/tag/maven-3.9.11 - apache/maven#2489 - apache/maven#2470 - apache/maven#10896 - apache/maven#2574 ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2331 from dongjoon-hyun/ORC-1958. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
to apache/orc
that referenced
this pull request
Jul 15, 2025
### What changes were proposed in this pull request? This PR aims to upgrade Maven to 3.9.11. ### Why are the changes needed? To bring the latest bug fixes. - https://github.com/apache/maven/releases/tag/maven-3.9.11 - apache/maven#2489 - apache/maven#2470 - apache/maven#10896 - apache/maven#2574 ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2331 from dongjoon-hyun/ORC-1958. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit ab9d7d0) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
Jul 17, 2025
### What changes were proposed in this pull request? This pr aims to upgrade maven 3.9.10 to 3.9.11. ### Why are the changes needed? The new version brings some bug fixes: - apache/maven#2489 - apache/maven#2470 The full release notes as follows: - https://github.com/apache/maven/releases/tag/maven-3.9.11 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass Github Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #51491 from LuciferYang/maven-3.9.11. Lead-authored-by: yangjie01 <[email protected]> Co-authored-by: YangJie <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
haoyangeng-db
pushed a commit
to haoyangeng-db/apache-spark
that referenced
this pull request
Jul 22, 2025
### What changes were proposed in this pull request? This pr aims to upgrade maven 3.9.10 to 3.9.11. ### Why are the changes needed? The new version brings some bug fixes: - apache/maven#2489 - apache/maven#2470 The full release notes as follows: - https://github.com/apache/maven/releases/tag/maven-3.9.11 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass Github Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#51491 from LuciferYang/maven-3.9.11. Lead-authored-by: yangjie01 <[email protected]> Co-authored-by: YangJie <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2487
Adds logic to de-duplicate the list of
MavenProjects being returned byFilteredProjectDependencyGraph.applyFilterto prevent building the same project multiple times in a parallel, multi-module build.A lengthy comment is added to the main change explaining a situation where the same project could be added multiple times, which I'll repeat here.
Given the following, simplified, aggregate POM where project E has a direct dependency on all of A, B, C, and D.
If a parallel build was using
--pl A,C,EifFilteredProjectDependencyGraph.applyFilterwas called with the aggregate POM'sMavenProjects (A, B, C, D, and E) and non-transitive and downstream dependencies were being filtered for, the following would happen.filteredresult as they're in the whitelist.This would result in project E being added to
filteredthree separate times. Once for being in the whitelist itself and twice more for being a downstream project of two projects not in the whitelist.I also added a small bit of logic to short circuit being distincting
filteredwhen it would effectively be a wasted no-op, when there is zero or one project in the list.Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.