-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[MNGSITE-393] remove references to Maven 2 #2438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
maven-model/src/main/mdo/maven.mdo
Outdated
| Version requirement can also be specified as a range of versions, e.g. <code>[3.2.0,)</code>. This is discouraged as it may break <i>predictability</i> of resolved version. | ||
| See <a href="https://s.apache.org/dependency-version">dependency version requirement documentation</a> | ||
| and <a href="https://s.apache.org/transitive-dependencies-resolution">transitive dependencies resolution</a> for more details. | ||
| The version of the dependency such as <code>3.2.1</code>. This can also be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This goes beyond removing references to Maven 2 and changes the wording and the semantics here. I'm really not sure that blurring the differences between a dependency constraint (or coordinates) and the `resolved dependency' is a good idea. We did not finish the discussion, but this goes opposite to the existing naming:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted most of this, with edits for corrections. I'm not sure it says as much as you're reading into it though.
| <code>partner</code> | ||
| (directly synced from a partner Maven 2 repository), <code>deployed</code> (was deployed from a Maven 2 | ||
| (directly synced from a partner Maven repository), <code>deployed</code> (was deployed from a Maven | ||
| instance), <code>verified</code> (has been hand verified as correct and final). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what this field is actually about. What are the tools that actually use this ? It's definitely not used in Maven core itself. How can we say what valid values are ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea. Maybe file an issue to figure this out. Possible this was removed from the code years ago and no one update the docs at the time.
|
look like cherry-pick: |
Not sure where this file has moved to in Maven 4, but for now this seems to be where the live site is pulled from.