[MNG-8764] centralize domain comparison logic Binding#getPriorityComparator
#2428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankraz76
changed the title
Binding to comparable to prevent feature envy following SOLID, leveraging OOP
rmannibucau
reviewed
Jun 4, 2025
impl/maven-di/src/main/java/org/apache/maven/di/impl/InjectorImpl.java
Outdated
Show resolved
Hide resolved
Pankraz76
commented
Jun 4, 2025
impl/maven-core/src/main/java/org/apache/maven/internal/impl/SisuDiBridgeModule.java
Outdated
Show resolved
Hide resolved
rmannibucau
reviewed
Jun 4, 2025
impl/maven-core/src/main/java/org/apache/maven/internal/impl/SisuDiBridgeModule.java
Show resolved
Hide resolved
Pankraz76
changed the title
Binding to comparable to prevent feature envy following SOLID, leveraging OOPBinding to comparable to prevent feature envy
Pankraz76
changed the title
Binding to comparable to prevent feature envyBinding to comparable
gnodet
reviewed
Jun 4, 2025
impl/maven-di/src/main/java/org/apache/maven/di/impl/Binding.java
Outdated
Show resolved
Hide resolved
gnodet
reviewed
Jun 4, 2025
impl/maven-core/src/main/java/org/apache/maven/internal/impl/SisuDiBridgeModule.java
Show resolved
Hide resolved
gnodet
reviewed
Jun 4, 2025
impl/maven-core/src/main/java/org/apache/maven/internal/impl/SisuDiBridgeModule.java
Show resolved
Hide resolved
gnodet
reviewed
Jun 4, 2025
impl/maven-di/src/main/java/org/apache/maven/di/impl/InjectorImpl.java
Outdated
Show resolved
Hide resolved
Pankraz76
changed the title
Binding to comparableBinding#getPriorityComparator
Pankraz76
force-pushed
the
fix-sortedBindings
branch
from
8f82a5e to
b58df1c
Compare
Pankraz76
changed the title
Binding#getPriorityComparatorBinding#getPriorityComparator
gnodet
approved these changes
Jun 4, 2025
rmannibucau
approved these changes
Jun 4, 2025
|
merci. |
Pankraz76
force-pushed
the
fix-sortedBindings
branch
from
b58df1c to
a2c4072
Compare
# Conflicts: # impl/maven-di/src/main/java/org/apache/maven/di/impl/InjectorImpl.java
|
this is what functional programming aka. clean code (uncle bob) ends up to. Simply OOP, as the functions are delated to some kind of domain If this method has missing override annotation, or not, changes not so much arch-design wise. Its a method at the end. Where it comes from, interface or custom, is random impl. detail again. Thanks for having SSOT, following SOLID. End up to all the principles, as jamming in the same direction. |
|
Resolve #9344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: MNG-8764