Skip to content

[MNG-8759] Restore toString method in DefaultJavaToolchain #2411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2025
Merged

[MNG-8759] Restore toString method in DefaultJavaToolchain #2411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions compat/maven-compat/src/main/java/org/apache/maven/toolchain/ToolchainManagerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,11 @@ public org.apache.maven.api.toolchain.ToolchainModel getModel() {
public boolean matchesRequirements(Map<String, String> requirements) {
return delegate.matchesRequirements(requirements);
}

@Override
public String toString() {
return delegate.toString();
}
}

private record ToolchainWrapperV3(org.apache.maven.api.Toolchain delegate) implements Toolchain, ToolchainPrivate {
Expand All @@ -235,5 +240,10 @@ public boolean matchesRequirements(Map<String, String> requirements) {
public ToolchainModel getModel() {
return new ToolchainModel(delegate.getModel());
}

@Override
public String toString() {
return delegate.toString();
}
}
}
5 changes: 5 additions & 0 deletions impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultJavaToolchainFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,11 @@ public boolean matchesRequirements(Map<String, String> requirements) {
}
return true;
}

@Override
public String toString() {
return "JDK[" + getJavaHome() + "]";
}
}

static final class ExactMatcher implements Predicate<String> {
Expand Down