Skip to content

Remove extra variable #2398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 6, 2025
Merged

Remove extra variable #2398

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f41990
Reapply "remove extra variable"
elharo May 28, 2025
35c9b13
spotless
elharo May 28, 2025
45b726e
fix
elharo May 28, 2025
2bbaf16
finalize argument
elharo May 28, 2025
d8b0edf
remove final
elharo Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultInterpolator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ private static String doSubstVars(
}

private static String processSubstitution(
String variable,
final String variable,
Copy link
Contributor

@Pankraz76 Pankraz76 May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boilerplate tradeoff naturally evolves to https://pmd.github.io/pmd/pmd_rules_java_bestpractices.html#avoidreassigningparameters.

Copy link
Contributor

@gnodet gnodet Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I don't like final parameters.

Copy link
Contributor

@Pankraz76 Pankraz76 Jun 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming you mean the explicit final declaration. Params should be treated final by default to avoid coupling, thus bugs.

Copy link
Contributor

@gnodet gnodet Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
final String variable,
String variable,

Copy link
Contributor Author

@elharo elharo Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Set<String> cycleMap,
Map<String, String> configProps,
UnaryOperator<String> callback,
Expand Down