Skip to content

Conversation

@cstamas
Copy link
Member

@cstamas cstamas commented May 1, 2025

The Sisu "strict" flag has issues, but also, it is best and simplest to help transitioning by making Sisu in Maven 4 behave in very same way as it behaves in Maven 3.


https://issues.apache.org/jira/browse/MNG-8614

The Sisu "strict" flag has issues, but also, it is best and
simplest to help transitioning by making Sisu in Maven 4
behave in very same way as it behaves in Maven 3.

---

https://issues.apache.org/jira/browse/MNG-8614
@cstamas cstamas added this to the 4.0.0-rc-4 milestone May 1, 2025
@cstamas cstamas self-assigned this May 1, 2025
@cstamas cstamas marked this pull request as ready for review May 1, 2025 18:50
@kwin
Copy link
Member

kwin commented May 1, 2025

Can't we fix the underlying issue in sisu rather? I am still convinced that throwing exceptions at least for incompatible bytecode is the right thing to do....

@cstamas
Copy link
Member Author

cstamas commented May 1, 2025

Even if we fix the issue, my point is to ease transition from Maven 3 to Maven 4, having Sisu behaving the same in both is just better, makes things simpler.

@cstamas
Copy link
Member Author

cstamas commented May 1, 2025

We can fix Sisu and make it strict in 4.1 or alike. I find this change (enabling strict) a bit disrupting for 4.0 that should allow easy transition from 3.x Maven.

@cstamas cstamas merged commit eb325e4 into apache:master May 5, 2025
13 checks passed
@cstamas cstamas deleted the MNG-8614 branch May 5, 2025 11:38
@jira-importer
Copy link

Resolve #9835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants