[MNG-8707] Add methods to remove compile and test source roots#2275
Merged
gnodet merged 10 commits intoapache:maven-3.9.xfrom Apr 30, 2025
Merged
[MNG-8707] Add methods to remove compile and test source roots#2275gnodet merged 10 commits intoapache:maven-3.9.xfrom
gnodet merged 10 commits intoapache:maven-3.9.xfrom
Conversation
…ollection modification
maven-core/src/main/java/org/apache/maven/project/MavenProject.java
Outdated
Show resolved
Hide resolved
slawekjaranowski
approved these changes
Apr 30, 2025
|
Resolve #9596 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA issue: MNG-8707
Add methods to remove compile and test source roots
Overview
This PR adds new methods to the
MavenProjectclass to allow removing source roots, complementing the existing methods for adding them. This provides a more complete API for managing source roots in Maven projects.Changes
removeCompileSourceRoot(String)method to remove a compile source rootremoveTestCompileSourceRoot(String)method to remove a test compile source rootremovePath(List<String>, String)utility method to handle path removalsanitizePath(String)method@since 3.9.10tags to new methodspath.length() > 0with!path.isEmpty()Implementation Details
LoggingListwrapper that logs warnings when collections are modified directlymaven.project.sourceRoots.warningsDisabledMotivation
These changes provide a more complete API for managing source roots, which is particularly useful for plugins that need to manipulate the source roots of a project during the build process.
Compatibility
This change is fully backward compatible. The new methods are marked with
@since 3.9.10to indicate when they were added.