Skip to content

[MNG-8305] Fix MER showErrors setting #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2024
Merged

[MNG-8305] Fix MER showErrors setting #1795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
230e878
[MNG-8305] Fix MER showErrors setting
cstamas Oct 14, 2024
dd01ccd
Alt fix
cstamas Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/maven-api-cli/src/main/java/org/apache/maven/api/cli/Options.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public interface Options {
Optional<Boolean> verbose();

/**
* Indicates whether to show error messages.
* Indicates whether to show error stack traces.
*
* @return an {@link Optional} containing the boolean flag, or empty if not set
*/
Expand Down
2 changes: 1 addition & 1 deletion maven-cli/src/main/java/org/apache/maven/cling/invoker/CommonsCliOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public Optional<Boolean> verbose() {

@Override
public Optional<Boolean> showErrors() {
if (commandLine.hasOption(CLIManager.SHOW_ERRORS)) {
if (commandLine.hasOption(CLIManager.SHOW_ERRORS) || verbose().orElse(false)) {
return Optional.of(Boolean.TRUE);
}
return Optional.empty();
Expand Down