Skip to content

More readable formatting of the warning about automatic modules #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnodet merged 1 commit into from
Sep 30, 2024
Merged

More readable formatting of the warning about automatic modules #1733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions maven-api-impl/src/main/java/org/apache/maven/internal/impl/PathModularizationCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,10 +178,11 @@ Optional<String> warningForFilenameBasedAutomodules(Collection<Path> modulePaths
if (automodulesDetected.isEmpty()) {
return Optional.empty();
}
String lineSeparator = System.lineSeparator();
var joiner = new StringJoiner(
", ",
"Filename-based automodules detected on the module-path: ",
"Please don't publish this project to a public artifact repository.");
lineSeparator + " - ",
"Filename-based automodules detected on the module-path: " + lineSeparator + " - ",
lineSeparator + "Please don't publish this project to a public artifact repository.");
automodulesDetected.forEach(joiner::add);
return Optional.of(joiner.toString());
}
Expand Down