Skip to content

Use Maven Wrapper to build #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Use Maven Wrapper to build #1548

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a903ea
Use Maven Wrapper to build
cstamas May 31, 2024
d4e473f
Typoi
cstamas May 31, 2024
acd381d
Add set up maven
cstamas May 31, 2024
5c4fc95
Use wrapper only in GitHub Actions
slawekjaranowski Jun 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,12 @@ jobs:
distribution: 'zulu'
cache: 'maven'

- name: Set up Maven
run:
mvn --errors --batch-mode --show-version org.apache.maven.plugins:maven-wrapper-plugin:3.3.2:wrapper "-Dmaven=3.9.7"

- name: Build with Maven
run: mvn verify -e -B -V -DdistributionFileName=apache-maven
run: ./mvnw verify -e -B -V -DdistributionFileName=apache-maven
Copy link
Member

@slawekjaranowski slawekjaranowski Jun 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before this step we can also add step Set up Maven with wrapper
and we not need add wrapper properties and scripts to code


- name: Upload built Maven
uses: actions/upload-artifact@v4
Expand Down Expand Up @@ -128,6 +132,10 @@ jobs:
distribution: 'zulu'
cache: 'maven'

- name: Set up Maven
run:
mvn --errors --batch-mode --show-version org.apache.maven.plugins:maven-wrapper-plugin:3.3.2:wrapper "-Dmaven=3.9.7"

- name: Running integration tests
shell: bash
run: mvn install -e -B -V -Prun-its,embedded -Dmaven.repo.local="$HOME/.m2/repository" -DmavenDistro="$GITHUB_WORKSPACE/built-maven/apache-maven-bin.zip" -f maven-integration-testing/pom.xml
run: ./mvnw install -e -B -V -Prun-its,embedded -Dmaven.repo.local="$HOME/.m2/repository" -DmavenDistro="$GITHUB_WORKSPACE/built-maven/apache-maven-bin.zip" -f maven-integration-testing/pom.xml