[maven-4.0.x] Resolve property before model reflection to avoid recursion (#11385, fixes #11384)#11390
Merged
gnodet merged 2 commits intoapache:maven-4.0.xfrom Nov 5, 2025
Merged
Conversation
…1385, fixes apache#11384) When a POM contains ${project.url} in the <url> field and also defines a property named 'project.url', Maven was incorrectly attempting to resolve the expression via model reflection first, which would return the same ${project.url} value, causing a recursive variable reference error. This fix changes the interpolation resolution order to check model properties before prefixed model reflection. This allows properties like 'project.url' to be resolved from the <properties> section before attempting to use reflection on the model object. The new resolution order is: 1. basedir 2. build.timestamp 3. user properties 4. model properties (moved up from position 5) 5. prefixed model reflection (moved down from position 3) 6. system properties 7. environment variables 8. unprefixed model reflection This change is consistent with the approach used for MNG-8469, which established that explicit property definitions should take precedence over model field reflection. Fixes apache#11384 (cherry picked from commit 727d80f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mastertomaven-4.0.x:Questions ?
Please refer to the Backport tool documentation