[MNG-8340] Staged 4.0.0-beta5 broken by maven-shade-plugin

[jira-importer]

Mateusz Gajewski opened MNG-8340 and commented

Reproduction: trinodb/trino#23849

 

Project structure:

> pom.xml
> client/trino-cli/pom.xml (parent.relativePath = ../../pom.xml)

maven-shade-plugin writes trino-cli dependency reduced pom to:

${project.build.directory}/pom.xml -> client/trino-cli/target/pom.xml

The file contains:

<parent>
   <relativePath>../../../pom.xml</relativePath>
</parent>

which correctly points to root pom.xml
 
This worked under beta4, fails under beta5 with:

[ERROR]     - [FATAL] 'parent.relativePath' points at '../../../pom.xml' but no POM could be found, please verify your project structure @ line 3, column 3 

It seems that parent.relativePath is resolved against client/trino-cli instead of client/trino-cli/target where pom.xml is placed.

---

Affects: 4.0.0-beta-5

Issue Links:

• MNG-8294 Add a consistency check when loading parent
  ("is caused by")

Remote Links:

• GitHub Pull Request #399
  
• GitHub Pull Request #400
  
• GitHub Pull Request #1857
  

Backported to: 4.0.0-rc-1

[jira-importer]

Guillaume Nodet commented

Full stack trace:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-install-plugin:3.1.3:install (default-install) on project trino-cli: 1 problem was  for io.trino:trino-cli:jar:463-SNAPSHOT
[ERROR]     - [FATAL] 'parent.relativePath' points at '../../../pom.xml' but no POM could be found, please verify your project structure @ line 3, column 3
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-install-plugin:3.1.3:install (default-install) on project trino-cli: 1 problem was  for io.trino:trino-cli:jar:463-SNAPSHOT
    - [FATAL] 'parent.relativePath' points at '../../../pom.xml' but no POM could be found, please verify your project structure @ line 3, column 3
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:346)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:310)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:214)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:179)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:168)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:165)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:107)
    at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject(SmartBuilderImpl.java:206)
    at io.takari.maven.builder.smart.SmartBuilderImpl$ProjectBuildTask.run(SmartBuilderImpl.java:71)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
    at java.util.concurrent.FutureTask.run(FutureTask.java:317)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
    at java.lang.Thread.run(Thread.java:1570)
Caused by: org.apache.maven.api.services.ModelBuilderException: 1 problem was  for io.trino:trino-cli:jar:463-SNAPSHOT
    - [FATAL] 'parent.relativePath' points at '../../../pom.xml' but no POM could be found, please verify your project structure @ line 3, column 3
    at org.apache.maven.internal.impl.model.DefaultModelBuilder$DefaultModelBuilderSession.newModelBuilderException(DefaultModelBuilder.java:532)
    at org.apache.maven.internal.impl.model.DefaultModelBuilder$DefaultModelBuilderSession.buildEffectiveModel(DefaultModelBuilder.java:863)
    at org.apache.maven.internal.impl.model.DefaultModelBuilder$1.build(DefaultModelBuilder.java:229)
    at org.apache.maven.internal.transformation.impl.DefaultConsumerPomBuilder.buildModel(DefaultConsumerPomBuilder.java:108)
    at org.apache.maven.internal.transformation.impl.DefaultConsumerPomBuilder.buildNonPom(DefaultConsumerPomBuilder.java:89)
    at org.apache.maven.internal.transformation.impl.DefaultConsumerPomBuilder.build(DefaultConsumerPomBuilder.java:76)
    at org.apache.maven.internal.transformation.impl.DefaultConsumerPomArtifactTransformer.transform(DefaultConsumerPomArtifactTransformer.java:116)
    at org.apache.maven.internal.transformation.impl.TransformedArtifact.mayUpdate(TransformedArtifact.java:119)
    at org.apache.maven.internal.transformation.impl.TransformedArtifact.getFile(TransformedArtifact.java:95)
    at org.apache.maven.RepositoryUtils.toArtifact(RepositoryUtils.java:159)
    at org.apache.maven.plugins.install.InstallMojo.processProject(InstallMojo.java:240)
    at org.apache.maven.plugins.install.InstallMojo.execute(InstallMojo.java:131)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:144)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:339)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:310)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:214)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:179)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:168)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:165)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:107)
    at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject(SmartBuilderImpl.java:206)
    at io.takari.maven.builder.smart.SmartBuilderImpl$ProjectBuildTask.run(SmartBuilderImpl.java:71)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
    at java.util.concurrent.FutureTask.run(FutureTask.java:317)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
    at java.lang.Thread.run(Thread.java:1570)
 

[jira-importer]

Guillaume Nodet commented

Very probably caused by MNG-8294

[jira-importer]

Mateusz Gajewski commented

Is this an issue with the shade plugin or with the api it consumes?

[jira-importer]

Guillaume Nodet commented

This is caused by an unwritten expectation of the shade plugin as to how the model building works.
Maven 3 assumes that if the POM file is replaced by another file using MavenProject#setFile(), then this new file location will be used when trying to locate the parent, while Maven 4 assumes the original POM location is used.
I need to check how I can solve the problem.
A workaround would be to use the default value for shade's mojo dependencyReducedPomLocation, so that the shaded pom will be located at ${basedir}/dependency-reduced-pom.xml.

[jira-importer]

Tamas Cservenak commented

I consider this call a bug in shade plugin:
https://github.com/apache/maven-shade-plugin/blob/911de58f6f5cb0811cb40ce161afa5e9c9196338/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java#L1200

As the distinction is clear IMO, plugin wants the other method:

maven/maven-core/src/main/java/org/apache/maven/project/MavenProject.java

Lines 245 to 257 in 3bad2f7

	public void setFile(File file) {
	this.file = file;
	this.basedir = file != null ? file.getParentFile() : null;
	}
	/**
	* Sets project {@code file} without changing project {@code basedir}.
	*
	* @since 3.2.4
	*/
	public void setPomFile(File file) {
	this.file = file;
	}

Set POM without altering basedir.

[jira-importer]

Guillaume Nodet commented

Right, but I'm not sure this will be sufficient.

When loading the parent, the ModelBuilder does not know about the project's basedir, only about the POM being loaded.

[jira-importer]

Guillaume Nodet commented

I may have to restore Maven 3 behavior.
I changed the behavior with this commit:
fee69f2#diff-2ca11f559cf3a8eea31dc3147fe812e1865f66f9d7783cde2196514747bc94ccR212-R268
which provides a custom Source implementation which points to a transformed file, but resolves from the original POM file. So another fix would be to resolve from the current POM, but I need to recompute the relative path of the parent when building the consumer POM (that's what shade plugin does).