[MNG-5356] Make encrypt/decrypt logic pluggable

[jira-importer]

Anders Hammar opened MNG-5356 and commented

It would be good if Maven Core facilitated the encryption (and decryption) logic to be replaceable. Today's solution is very much hard-coded to the plexus logic.

This would make it possible for enterprise environments to re-use existing solutions, like for eg smart cards, for this. The default should be the current implementation though.

---

Issue Links:

• MNG-5615 Rework credentials handling

1 votes, 9 watchers

[jira-importer]

Anders Hammar commented

We should add an interface for this using org.apache.maven namespace and a default implementation which could be a simple wrapper on the current existing impl.

[jira-importer]

Anders Hammar commented

The work on this is performed here: https://github.com/devoteam-se/maven-3/tree/MNG-5356

[jira-importer]

Jason van Zyl commented

If this is really just a resuable encrypt/decrypt component I would recommend separating it from the core.

[jira-importer]

Jason van Zyl commented

Have you taken a look at the SettingsDecrypter in maven-settings-builder? I'll pull your branch in and take a closer look now that 3.1.0 is almost wrapped up.

[jira-importer]

Anders Hammar commented

Yes, DefaultSettingsDecrypter uses the new Crypto component.

[jira-importer]

Anders Hammar commented

When/if we do this we also need to update the maven-deps image of the site.

[jira-importer]

Dominik Richner commented

Could we not extend this to allow full password resolution instead of just decryption?
e.g. in a CI environment we would like the CI server to manage the passwords.

[jira-importer]

Anders Hammar commented

@Dominik: That would be great and also one of my wishes. It would require involvement of people with knowledge of those requirements though. Initially I though of this as a first step which could then be improved with what you're talking about.
I first step for the "full password resolution" would be to create tickets with some CI server (e.g. Jenkins or Hudson) and link to this ticket. This could trigger participation to move this forward. Please go ahead and do this!

[jira-importer]

Dominik Richner commented

The issue already exists in Jenkins (https://issues.jenkins-ci.org/browse/JENKINS-16705) and I also resolved it by implementing it this way: https://wiki.jenkins-ci.org/display/JENKINS/Config+File+Provider+Plugin#ConfigFileProviderPlugin-MavenServerCredentials%28since2.7%29

Technically the current solution in Jenkins is done by rewriting the settings.xml and and passing it with "-s" and "-g" - but if maven would provide a plugable solution, I could implement it in a more elegant way.

...I don't know about Hudson...

[jira-importer]

Michael Osipov commented

This issue has been auto closed because it has been inactive for a long period of time. If you think this issue still applies, retest your problem with the most recent version of Maven and the affected component, reopen and post your results.