-
Notifications
You must be signed in to change notification settings - Fork 96
Open
Labels
enhancementNew feature or requestNew feature or requestpriority:minorMinor loss of function, or other problem where easy workaround is presentMinor loss of function, or other problem where easy workaround is present
Description
wei cai opened MWAR-445 and commented
Currently to build a war archive, maven-war-plugin need:
- source paths (libraries, src/main/webapp...) -> exploded war -> build archive
Many files need to be copied to exploded war directory before creating war archive.
To speed up the maven-war-plugin, I would like to propose below solution:
- source paths (libraries, src/main/webapp...) -> build archive
Here when "-Dmaven.war.exploded.skip=true" is passed, the maven-war-plugin then build the archive directly based on all source paths, in this way, massive file copying can be avoided.
maven.war.exploded.skip is by default set as false as there might be a few cases user want an exploded war, for example:
- Using tomcat7-maven-plugin to start exploded webapp
I created the PR: #21 for initial discussion.
Please help review and advise:
- Does it make sense to skip the creation of exploded war? Any features will break because of this?
- Regarding the ITs, shall I separate the tests into 2 scenarios?
- ITs for original behavior.
- ITs for building war archive without creating exploded war.
Affects: 3.3.2
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestpriority:minorMinor loss of function, or other problem where easy workaround is presentMinor loss of function, or other problem where easy workaround is present