[MRESOLVER-369] Introduce update check policy scope #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces new configuration: update check policy scope, that limits where (artifact, metadata, both) the update policy is applied. If update policy is not applied, presence/absence decides instead. To achieve "old" behaviour (ie. for use in Maven3), the configuration properties should always be set to "all" in session factory. --- https://issues.apache.org/jira/browse/MRESOLVER-369
cstamas
commented
Jun 11, 2023
...-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManager.java
Outdated
Show resolved
Hide resolved
gnodet
approved these changes
Jun 12, 2023
Member
Author
|
PR is on-hold: testing shows that now when Maven "remembers" that Artifact cannot be downloaded, there is no way to get out of it (-U does not help, as policy is not applied to artifact by default anymore, before it simply went here as -U was "always", and implicitly cleared the error flags as well, so it "fixed" things). IMO, this stems from the fact that policy ALWAYS was simply misused on Maven side (-U), and instead, "force update" on maven side may mean something else, like:
|
Member
Author
|
MRESOLVER-377 is proper fix |
|
Resolve #1044 |
1 similar comment
|
Resolve #1044 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces new configuration: update check policy scope, that limits where (artifact, metadata, both) the update policy is applied. If update policy is not applied, presence/absence decides instead.
To achieve "old" behaviour (ie. for use in Maven3), the configuration properties should always be set to "all" in session factory.
https://issues.apache.org/jira/browse/MRESOLVER-369