Conversation
Plugin used a lot of legacy code, misused Mojo test case and used old Junit 3.x TestCase, and missed some dependencies (junit mostly).
Contributor
|
I wonder if we should switch to junit 5 rather than going to junit 4. It has been out for 4 years now. I've done such a migration a few times, so I can work on it when those PRs are merged. |
Member
Author
|
I am for it, but for now at least this PR aligns tests in this project, does not mix junit3 and junit4 anymore... |
gnodet
approved these changes
Oct 14, 2021
hboutemy
approved these changes
Oct 21, 2021
|
Resolve #693 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin used a lot of legacy code, misused Mojo test case
and used old Junit 3.x TestCase, and missed some
dependencies (junit mostly).
Changes:
Project cleaned up locally with help of apache/maven-parent#33
(locally modified parent and bashed POMs as long there were enforcer failures).
This PR continues work done in #37 and will be merged AFTER IT.