Skip to content

[MPLUGINTESTING-80] Upgrade to maven 4.0.0-alpha-4 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2023
Merged

[MPLUGINTESTING-80] Upgrade to maven 4.0.0-alpha-4 #27

merged 1 commit into from
Feb 15, 2023

Conversation

@gnodet
Copy link
Contributor

@gnodet gnodet commented Jan 30, 2023 •
edited
Loading

@gnodet gnodet force-pushed the MPLUGINTESTING-80 branch from 62ca1d9 to db499d7 Compare January 30, 2023 10:00
@michael-o
Copy link
Member

michael-o commented Feb 14, 2023

Is this still backward compatible?

@gnodet
Copy link
Contributor Author

gnodet commented Feb 14, 2023 •
edited
Loading

Is this still backward compatible?

The upgrade from 4.0.0-alpha-2 to alpha-4 ? The renaming from Dom to XmlNode is definitely not, but that's why they are alpha releases.

If you're asking about the upgrade from 3 to 4, that was done in #24, the change should be compatible as the v4 api is supported through new classes in a different package https://github.com/apache/maven-plugin-testing/tree/master/maven-plugin-testing-harness/src/main/java/org/apache/maven/api/plugin/testing
Also, the version has been updated to 4.0.0-SNAPSHOT in the PR above

@gnodet gnodet added this to the 4.0.0-alpha-1 milestone Feb 14, 2023
@gnodet
Copy link
Contributor Author

gnodet commented Feb 14, 2023

Is this still backward compatible?

The upgrade from 4.0.0-alpha-2 to alpha-4 ? The renaming from Dom to XmlNode is definitely not, but that's why they are alpha releases.

If you're asking about the upgrade from 3 to 4, that was done in #24, the change should be compatible as the v4 api is supported through new classes in a different package https://github.com/apache/maven-plugin-testing/tree/master/maven-plugin-testing-harness/src/main/java/org/apache/maven/api/plugin/testing Also, the version has been updated to 4.0.0-SNAPSHOT in the PR above

I'm planning a 4.0.0-alpha-1 release, as there may be a few iterations while we work on various plugins.

@michael-o
Copy link
Member

michael-o commented Feb 14, 2023

Is this still backward compatible?

The upgrade from 4.0.0-alpha-2 to alpha-4 ? The renaming from Dom to XmlNode is definitely not, but that's why they are alpha releases.

If you're asking about the upgrade from 3 to 4, that was done in #24, the change should be compatible as the v4 api is supported through new classes in a different package https://github.com/apache/maven-plugin-testing/tree/master/maven-plugin-testing-harness/src/main/java/org/apache/maven/api/plugin/testing Also, the version has been updated to 4.0.0-SNAPSHOT in the PR above

Yes, my bad. I did not pay attention to it.

@gnodet gnodet added the dependencies Pull requests that update a dependency file label Feb 14, 2023
@gnodet gnodet merged commit b9454c2 into apache:master Feb 15, 2023
@gnodet gnodet deleted the MPLUGINTESTING-80 branch February 15, 2023 09:27
@jira-importer
Copy link

jira-importer commented Jul 16, 2025

Resolve #181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-o michael-o michael-o approved these changes

Assignees

@gnodet gnodet

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

4.0.0-alpha-1

Development

Successfully merging this pull request may close these issues.

3 participants

@gnodet @michael-o @jira-importer