Skip to content

Conversation

@slawekjaranowski
Copy link
Member

Following this checklist to help us incorporate your contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Maven site descriptor format from the deprecated DECORATION/1.8.0 to the newer SITE/2.0.0 schema, fixes documentation issues, and streamlines GitHub workflow automation.

Key changes:

  • Migrates site.xml files from <project> with DECORATION schema to <site> with SITE/2.0.0 schema
  • Updates FAQ documentation to highlight JUnit 5 as the preferred testing approach and marks older methods as deprecated
  • Corrects a spelling error and adds a reference link to plugin testing documentation

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/site/site.xml Updated root element and schema from DECORATION/1.8.0 to SITE/2.0.0
maven-plugin-testing-harness/src/site/site.xml Updated root element and schema from DECORATION/1.8.0 to SITE/2.0.0
maven-plugin-testing-harness/src/site/markdown/index.md Removed blank line and added plugin testing summary reference link
maven-plugin-testing-harness/src/site/fml/faq.fml Fixed typo, promoted JUnit 5 extension, deprecated old testing methods, removed obsolete Maven 2.x FAQ
.github/workflows/pr-automation.yml Removed unused workflow trigger types

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@slawekjaranowski slawekjaranowski merged commit 53bcad7 into apache:maven-plugin-testing-3.x Oct 28, 2025
20 checks passed
@slawekjaranowski slawekjaranowski deleted the site-desc-2.0 branch October 28, 2025 21:27
@github-actions github-actions bot added this to the 3.4.0 milestone Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant