Introduce MemoryAccountingBitsetCollectorManager#15795
Open
gaobinlong wants to merge 4 commits intoapache:mainfrom
Open
Introduce MemoryAccountingBitsetCollectorManager#15795gaobinlong wants to merge 4 commits intoapache:mainfrom
gaobinlong wants to merge 4 commits intoapache:mainfrom
Conversation
Signed-off-by: Binlong Gao <[email protected]>
Signed-off-by: Binlong Gao <[email protected]>
gaobinlong
commented
Mar 6, 2026
| protected void doSetNextReader(LeafReaderContext context) throws IOException { | ||
| docBase = context.docBase; | ||
| length += context.reader().maxDoc(); | ||
| length = docBase + context.reader().maxDoc(); |
Contributor
Author
There was a problem hiding this comment.
This change works for both single-thread case and concurrency search case, the original code doesn't work for concurrency search case since length always starts from 0 for each collector.
Contributor
There was a problem hiding this comment.
Does this mean we're creating a maxDoc-length FixedBitSet for every thread? I wonder if there's a way of being more memory efficient here?
Contributor
Author
There was a problem hiding this comment.
I've refactored the code to make it memory efficient for concurrent search case, please take a look, thanks!
Contributor
Author
|
Hi @romseygeek , would you mind taking look into this PR? Thank you~ |
Signed-off-by: Binlong Gao <[email protected]>
…setCollectorManager
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr introduces MemoryAccountingBitsetCollectorManager and switches TestMemoryAccountingBitsetCollector.java to use search concurrency and move away from the deprecated search(Query, Collector) method.
Relates to #12892.