Skip to content

Fix incorrect parameter names in GradientFormatter error messages #15781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vinaykpud wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −5
Open

Fix incorrect parameter names in GradientFormatter error messages #15781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef2191d
Fix incorrect parameter names in GradientFormatter error messages
vinaykpud Feb 28, 2026
d68c145
Add CHANGES.txt entry
vinaykpud Feb 28, 2026
92aac21
updated the changes
vinaykpud Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lucene/CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,8 @@ Bug Fixes
* GITHUB#14971: Fix CachedExecutor thread pool leak in ConcurrentMergeScheduler
when IndexWriter initialization fails. (Su Beom)

* GITHUB#15781: Fix incorrect parameter names in GradientFormatter error messages. (Vinay Krishna Pudyodu)

Changes in Runtime Behavior
---------------------
* GITHUB#14187: The query cache is now disabled by default. (Adrien Grand)
Expand Down
7 changes: 2 additions & 5 deletions lucene/highlighter/src/java/org/apache/lucene/search/highlight/GradientFormatter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public GradientFormatter(
}
if (maxForegroundColor.length() != 7) {
throw new IllegalArgumentException(
"minForegroundColor is not 7 bytes long eg a hex " + "RGB value such as #FFFFFF");
"maxForegroundColor is not 7 bytes long eg a hex " + "RGB value such as #FFFFFF");
}
fgRMin = hexToInt(minForegroundColor.substring(1, 3));
fgGMin = hexToInt(minForegroundColor.substring(3, 5));
Expand All @@ -77,7 +77,7 @@ public GradientFormatter(
}
if (maxBackgroundColor.length() != 7) {
throw new IllegalArgumentException(
"minBackgroundColor is not 7 bytes long eg a hex " + "RGB value such as #FFFFFF");
"maxBackgroundColor is not 7 bytes long eg a hex " + "RGB value such as #FFFFFF");
}
bgRMin = hexToInt(minBackgroundColor.substring(1, 3));
bgGMin = hexToInt(minBackgroundColor.substring(3, 5));
Expand All @@ -87,14 +87,11 @@ public GradientFormatter(
bgGMax = hexToInt(maxBackgroundColor.substring(3, 5));
bgBMax = hexToInt(maxBackgroundColor.substring(5, 7));
}
// this.corpusReader = corpusReader;
this.maxScore = maxScore;
// totalNumDocs = corpusReader.numDocs();
}

@Override
public String highlightTerm(String originalText, TokenGroup tokenGroup) {
if (tokenGroup.getTotalScore() == 0) return originalText;
float score = tokenGroup.getTotalScore();
if (score == 0) {
return originalText;
Expand Down
Loading