Remove the scorer on FlatVectorsReader#15316
Conversation
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
thecoop
force-pushed
the
remove-flat-vector-scorer
branch
from
f0e0160 to
1af7362
Compare
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
thecoop
force-pushed
the
remove-flat-vector-scorer
branch
from
1af7362 to
b8b6d46
Compare
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
| /** | ||
| * @return the {@link FlatVectorsScorer} for this reader. | ||
| */ | ||
| public FlatVectorsScorer getFlatVectorScorer() { |
There was a problem hiding this comment.
This is a breaking change that can't be back-ported -- do we think nobody would ever want to use this? Would we still provide the scorer for cases where we want to score vectors externally?
There was a problem hiding this comment.
There's nothing stopping subclasses from having a scorer, and exposing it, but this method is specifically not used in Lucene in the context of the general FlatVectorsReader
There was a problem hiding this comment.
This is a breaking change that can't be back-ported
This class is marked * @lucene.experimental. I thought that meant things could break?
There was a problem hiding this comment.
yeah I guess, but ... is it important to remove? I guess I'm thinkning of a case where a consumer wants to get a vector values and score against it to implement something like rescoring/ranking -- isn't this something we'd want to support? Or maybe I'm confused and this method is not needed for that use case?
There was a problem hiding this comment.
I guess I'm thinkning of a case where a consumer wants to get a vector values and score against it to implement something like rescoring/ranking
[Float|Byte]VectorValues provides mechanisms for bulk scoring and bulk rescoring. But sure, I could still see this being used if folks had specialized logic.
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
3 participants
Turns out the scorer isn't actual used by
FlatVectorsReaderdirectly, only on specific subclasses