Use a hint to specify READONCE IOContext#14509
Merged
ChrisHegarty merged 2 commits intoapache:mainfrom May 29, 2025
Merged
Conversation
github-project-automation
Bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
Contributor
|
Could we get some context/issue what this is about? |
Contributor
Author
thecoop
force-pushed
the
iocontext-readonce-hint
branch
from
62fffb2 to
b981dd3
Compare
thecoop
force-pushed
the
iocontext-readonce-hint
branch
from
b981dd3 to
ff5067e
Compare
Contributor
Author
|
@ChrisHegarty @jpountz Does this look ok? |
jpountz
reviewed
May 15, 2025
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
I left a few comments/questions but the change makes sense to me.
| */ | ||
| package org.apache.lucene.store; | ||
|
|
||
| /** A {@link IOContext.FileOpenHint} indicating the file will only be read once, sequentially */ |
Contributor
There was a problem hiding this comment.
It would be interesting to use MockDirectoryWrapper to check that files that open with this hint actually read the data only once and sequentially (in a follow-up PR).
Contributor
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you will stop receiving this reminder on future updates to the PR. |
jpountz
approved these changes
May 25, 2025
github-project-automation
Bot
moved this from Open
to Merged
in OpenSearch Lucene & Core Performance Tracking
ChrisHegarty
pushed a commit
that referenced
this pull request
May 29, 2025
Use a hint to specify readonce IO, rather than checking for object identity (which we shouldn't really be doing with records anyway)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a hint to specify readonce IO, rather than checking for object identity (which we shouldn't really be doing with records anyway)