Skip to content

SOLR-8639 replace static SimpleDateFormat with threadsafe jodatimeDateFormatter#5

Closed
mbreslow wants to merge 2 commits intoapache:masterfrom
DevFactory:SOLR-8639-replace-static-sdf-with-jodatime
Closed

SOLR-8639 replace static SimpleDateFormat with threadsafe jodatimeDateFormatter#5
mbreslow wants to merge 2 commits intoapache:masterfrom
DevFactory:SOLR-8639-replace-static-sdf-with-jodatime

Conversation

@mbreslow
Copy link
Copy Markdown

@mbreslow mbreslow commented Feb 4, 2016

Resolve issue SOLR-8639:
sinceDateParser and afterFmt are declared as static variables of type SimpleDateFormat which is not threadsafe. This may cause data corruption and an incorrect value to be returned by the methods that use them.

…eFormatter instances from joda-time.

The joda-time types are threadsafe which is appropriate for this usecase. Keeping the SDF instances could
cause data corruption or incorrect values to be returned from the methods that use them.
dragonsinth referenced this pull request in fullstorydev/lucene-solr Feb 12, 2016
LUCENE-6740: Reduce warnings emitted by javac #5

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/branches/branch_5x@1696077 13f79535-47bb-0310-9956-ffa450edef68
mnilsson23 added a commit to mnilsson23/lucene-solr that referenced this pull request Jul 6, 2016
…list-not-collection

LTRScoringAlgorithm's allFeatures is now List instead of Collection
desultir added a commit to desultir/lucene-solr that referenced this pull request Sep 6, 2016
dsmiley pushed a commit to dsmiley/lucene-solr that referenced this pull request Jun 22, 2018
munendrasn added a commit to munendrasn/lucene-solr that referenced this pull request Jun 3, 2020
@madrob
Copy link
Copy Markdown
Contributor

madrob commented Sep 21, 2020

DIH has been moved out to an external package, please consider submitting your patch to https://github.com/rohitbemax/dataimporthandler - thank you!

@madrob madrob closed this Sep 21, 2020
bszabo97 pushed a commit to bszabo97/lucene-solr that referenced this pull request Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants