SOLR-8785: Use Metrics library for core metrics#25
Closed
randomstatistic wants to merge 3 commits intoapache:masterfrom
Closed
SOLR-8785: Use Metrics library for core metrics#25randomstatistic wants to merge 3 commits intoapache:masterfrom
randomstatistic wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
|
https://issues.apache.org/jira/browse/SOLR-8785 was implemented in Solr 6.4, so this PR can be closed. |
bszabo97
pushed a commit
to bszabo97/lucene-solr
that referenced
this pull request
Mar 18, 2021
zacharymorn
added a commit
to zacharymorn/lucene-solr
that referenced
this pull request
Mar 27, 2021
…s are indexed for a FacetLabel (apache#25) (cherry picked from commit 3648a1020a8ab6b729ed53e0360499e624bb0cd1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were three main areas that used the copied classes in org.apache.solr.util.stats:
This patch adds depreciation tags to all the copied classes, and also replaces all usage of those classes with classes from the Metrics library.
I added one new class (org.apache.solr.util.stats.Metrics) to provide some common access patterns for metrics gathering.
This patch only adds Registry-based tracking to RequestHandlerBase, although all three areas are a fit for it. The effect is that all one needs to do is add a Reporter to the SharedMetricRegistry named “solr.registry.requesthandler” and all named request handler stats will be exported automatically.
Compatibility notes: