Watchdog support for Spark-3.2 #1591
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfmcgrady
force-pushed
the
watchdog-spark32
branch
from
e0ab111 to
44726de
Compare
Codecov Report
@@ Coverage Diff @@
## master #1591 +/- ##
============================================
- Coverage 59.02% 58.06% -0.96%
+ Complexity 196 140 -56
============================================
Files 256 256
Lines 12708 12683 -25
Branches 1601 1596 -5
============================================
- Hits 7501 7365 -136
- Misses 4570 4695 +125
+ Partials 637 623 -14
Continue to review full report at Codecov.
|
Contributor
Author
|
cc @ulysses-you and watchdog original author @zhouyifan279 @i7xh |
cfmcgrady
commented
Dec 20, 2021
| |SELECT * FROM t2 | ||
| |$sort | ||
| |LIMIT $limit | ||
| |""".stripMargin).queryExecution.optimizedPlan.maxRows.contains(expected)) |
Contributor
Author
There was a problem hiding this comment.
As WithCTE.maxRows is None, we should check optimizedPlan here.
cfmcgrady
commented
Dec 20, 2021
| |$having | ||
| |$sort | ||
| |LIMIT $limit | ||
| |""".stripMargin).queryExecution.optimizedPlan.maxRows.contains(expected)) |
Contributor
Author
There was a problem hiding this comment.
ulysses-you
reviewed
Dec 20, 2021
|
|
||
| } | ||
|
|
||
| trait MarkAggregateOrderBase extends Rule[LogicalPlan] { |
Contributor
There was a problem hiding this comment.
For Spark 3.2, we don't need MarkAggregateOrderBase about aggregate since apache/spark#32470. We only need CTE.
ulysses-you
approved these changes
Dec 21, 2021
Contributor
|
thanks, merging to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
ForcedMaxOutputRowsRuleto spark-common and rename toForcedMaxOutputRowsBaseWithCTElogical plan in spark-3.2MaxPartitionStrategyto spark-commonForcedMaxOutputRowsRuleHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request