Skip to content

Conversation

@gnodet
Copy link
Contributor

@gnodet gnodet commented Nov 27, 2024

Karaf won't work with Maven 4.0.0-rc-1 (under vote), but this PR will get it ready to build with 4.0.0-rc-2.

@jbonofre jbonofre merged commit df02ef6 into apache:main Nov 28, 2024
@jherkel
Copy link

jherkel commented Dec 2, 2024

@gnodet I tried the latest mvnd 4.0 rc1 and I could see this exception:
Caused by: java.lang.NullPointerException: Cannot invoke "java.io.File.exists()" because the return value of "org.apache.maven.execution.MavenExecutionRequest.getUserSettingsFile()" is null at org.apache.karaf.tooling.VerifyMojo.execute(VerifyMojo.java:198) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:144) at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:339) at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:310)

Sorry for reusing this issue but I'm not sure if your commit also solves exception above or there must be checks for null value returned by MavenExecutionRequest.getUserSettingsFile().

@gnodet
Copy link
Contributor Author

gnodet commented Dec 2, 2024

@gnodet I tried the latest mvnd 4.0 rc1 and I could see this exception: Caused by: java.lang.NullPointerException: Cannot invoke "java.io.File.exists()" because the return value of "org.apache.maven.execution.MavenExecutionRequest.getUserSettingsFile()" is null at org.apache.karaf.tooling.VerifyMojo.execute(VerifyMojo.java:198) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:144) at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:339) at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:310)

Sorry for reusing this issue but I'm not sure if your commit also solves exception above or there must be checks for null value returned by MavenExecutionRequest.getUserSettingsFile().

Yes, the issue has been raised already and fixed in Maven master, so it'll work with rc2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants