MINOR: Adjust test params pursuant to KAFKA-4514. #5777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hachikuji
reviewed
Oct 10, 2018
|
|
||
| @cluster(num_nodes=7) | ||
| @cluster(num_nodes=8) | ||
| @parametrize(compression_types=["snappy","gzip","lz4","zstd","none"]) |
Contributor
There was a problem hiding this comment.
nit: there's a comment below that still refers to num_producers=4. Would be nice to figure find a way to make the dependence on the parameterization explicit. I wonder if we could make the list of compression types a static value and refer to its size when defining num_producers and num_nodes? Not a requirement, but if it's easy to do.
hachikuji
approved these changes
Oct 10, 2018
Contributor
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix!
Contributor
|
I will go ahead and merge since the build does not verify system tests. |
Contributor
|
The update looks good. |
hachikuji
pushed a commit
that referenced
this pull request
Oct 10, 2018
PR #2267 Introduced support for Zstandard compression. The relevant test expects values for `num_nodes` and `num_producers` based on the (now-incremented) count of compression types. Passed the affected, previously-failing test: `ducker-ak test tests/kafkatest/tests/client/compression_test.py` Reviewers: Jason Gustafson <[email protected]>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
PR apache#2267 Introduced support for Zstandard compression. The relevant test expects values for `num_nodes` and `num_producers` based on the (now-incremented) count of compression types. Passed the affected, previously-failing test: `ducker-ak test tests/kafkatest/tests/client/compression_test.py` Reviewers: Jason Gustafson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2267 Introduced support for Zstandard compression. The relevant test expects values for
num_nodesandnum_producersbased on the (now-incremented) count of compression types.Passed the affected, previously-failing test:
ducker-ak test tests/kafkatest/tests/client/compression_test.py