JCR-5127 Deprecate constants which are defined in expanded form in JCR#221
JCR-5127 Deprecate constants which are defined in expanded form in JCR#221
Conversation
jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/JcrConstants.java
Outdated
Show resolved
Hide resolved
kwin
force-pushed
the
feature/deprecate-jcr-constants
branch
from
af9b19f to
f24a17f
Compare
Amoratinos
left a comment
Amoratinos
left a comment
There was a problem hiding this comment.
I cannot add a comment on line 327 but couldn't be replace the jcr:path constant by the one javax.jcr.Property#JCR_PATH.
jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/JcrConstants.java
Show resolved
Hide resolved
Yes, but according to its javadoc this is supposed to be used with query results (and this refers to a pseudo property). Not sure if expanded names are supported for all use cases here. |
kwin
force-pushed
the
feature/deprecate-jcr-constants
branch
from
f24a17f to
4bfe375
Compare
|
There are some edge cases which require currently qualified form (e.g. comparing Item‘s name against a Set of literals), therefore I am not sure we can really deprecate… |
jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/JcrConstants.java
Outdated
Show resolved
Hide resolved
jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/JcrConstants.java
Outdated
Show resolved
Hide resolved
2.0 API Highlight where expanded form names should be used instead
kwin
force-pushed
the
feature/deprecate-jcr-constants
branch
from
4bfe375 to
7fb9097
Compare
|
Please have a look again the PR, I no longer deprecated as there are valid use cases which require the qualified form. Instead I just link out to the alternative in the javadoc. |
2.0 API Highlight where expanded form names should be used instead
3 participants
2.0 API