OAK-12071: fix property removal for externally modifiable indexes#2700
Merged
fabriziofortino merged 6 commits intoapache:trunkfrom Jan 27, 2026
Merged
OAK-12071: fix property removal for externally modifiable indexes#2700fabriziofortino merged 6 commits intoapache:trunkfrom
fabriziofortino merged 6 commits intoapache:trunkfrom
Conversation
nit0906
previously approved these changes
Jan 27, 2026
Contributor
The failing test itself however could be improved a bit imo. The last assertion
should rather be assertEventually(() -> assertQuery("/jcr:root//*[jcr:contains(@" + mulValuedProp + ", 'bar')]", "xpath", new ArrayList<>())); |
Contributor
Author
|
@nit0906 can you review again? There was an issue with the logic but the test was passing locally. |
nit0906
approved these changes
Jan 27, 2026
reschke
pushed a commit
that referenced
this pull request
Feb 15, 2026
) * OAK-12071: fix property removal for externally modifiable indexes * OAK-12071: fix flaky test increasing eventual assertion time * OAK-12071: test improvements * OAK-12071: ensure index name uniqueness in tests * OAK-12071: fix case where properties are not correctly removed * OAK-12071: minor code improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.