Correct binary column memory calculation #14796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14796 +/- ##
============================================
+ Coverage 39.34% 39.35% +0.01%
Complexity 193 193
============================================
Files 4489 4490 +1
Lines 286231 286231
Branches 35484 35484
============================================
+ Hits 112618 112649 +31
+ Misses 173613 173582 -31 ☔ View full report in Codecov by Sentry. |
jt2594838
approved these changes
Feb 7, 2025
JackieTien97
added a commit
that referenced
this pull request
Jun 16, 2025
* use getSizeInBytes instead of getRetainedSizeInBytes in some places * change tsfile version (cherry picked from commit a49958c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the tsfile dependency to use the apache/tsfile#384