-
Notifications
You must be signed in to change notification settings - Fork 8.9k
Fix #7869: Rename vgroup_table.cluster to cluster_name #7925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.x
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7925 +/- ##
============================================
+ Coverage 71.58% 71.59% +0.01%
Complexity 883 883
============================================
Files 1294 1294
Lines 49554 49555 +1
Branches 5884 5885 +1
============================================
+ Hits 35475 35481 +6
+ Misses 11159 11158 -1
+ Partials 2920 2916 -4
🚀 New features to boost your workflow:
|
|
Hi maintainers, I’ve addressed the SQL rename across all supported databases, added upgrade scripts, and included tests to improve coverage. License and Spotless checks are now passing locally. Thanks for your review. |
| `namespace` VARCHAR(255), | ||
| `cluster` VARCHAR(255), | ||
| UNIQUE KEY `idx_vgroup_namespace_cluster` (`vGroup`,`namespace`,`cluster`) | ||
| `cluster_name` VARCHAR(255), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we rename the column cluster to cluster_name,
what should we do with the existing vgroup data that has already been migrated to NamingServer for transaction group management?
How should the migration process to the new table structure be handled?
What this PR does:
clustervgroup_table.clustertocluster_nameacross all supported databasesWhy this approach:
Backward compatibility:
Fixes #7869