bugfix: fix Byte[] type to ensure the correct primary key value.#7761
Merged
slievrly merged 6 commits intoapache:2.xfrom Nov 2, 2025
Merged
bugfix: fix Byte[] type to ensure the correct primary key value.#7761slievrly merged 6 commits intoapache:2.xfrom
slievrly merged 6 commits intoapache:2.xfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #7761 +/- ##
============================================
- Coverage 67.62% 67.61% -0.01%
- Complexity 992 994 +2
============================================
Files 1323 1323
Lines 50155 50157 +2
Branches 5928 5929 +1
============================================
- Hits 33915 33912 -3
- Misses 13316 13317 +1
- Partials 2924 2928 +4
🚀 New features to boost your workflow:
|
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
When the primary key is of type
BINARY(16),pkValis actually abyte[]array.For a
byte[]array,StringBuilder.append(Object obj)callsobj.toString().The default
toString()method ofbyte[]returns a string representing the memory address of the Java object.This address string is stored in the
pkfield of the global lock tablelock_table.The problem lies in the undo_log serialization logic: it correctly serializes the contents of the
byte[]array, not the memory address.My solution: Based on the
buildLockKey, I performed special processing on thebyte[]type. CallingArrayUtils.toString(pkVal)returns the actual content instead of the memory address.In addition, I added corresponding unit tests to verify the correctness of the modification.
Ⅱ. Does this pull request fix one issue?
fixes #7738
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
mvn clean test
Ⅴ. Special notes for reviews